Allon Mureinik has posted comments on this change.
Change subject: restapi: generalize getStoragePoolIdForDomain
......................................................................
Patch Set 1:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-08-22 23:53:33 +0200
Line 4: Commit: Federico Simoncelli <fsimo...@redhat.com>
Line 5: CommitDate: 2013-08-22 23:55:10 +0200
Line 6:
Line 7: restapi: generalize getStoragePoolIdForDomain
the term generalize in Java is often used in the context of applying generics
(e.g., changing a method's return value from List to List<StorageDomain>).
Consider change the subject to "extracting getStoragePoolIdForDomain"
Line 8:
Line 9: Change-Id: I176c8508de20e729d7c8b851aa3733cc0aa596cb
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 109: }
Line 110: return clz.cast(result.getReturnValue());
Line 111: }
Line 112:
Line 113: public <T> List<T> getBackendCollection(Class<T> clz,
VdcQueryType query, VdcQueryParametersBase queryParams) {
why is this needed?
Line 114: try {
Line 115: VdcQueryReturnValue result = runQuery(query, queryParams);
Line 116: if (!result.getSucceeded()) {
Line 117: backendFailure(result.getExceptionString());
--
To view, visit http://gerrit.ovirt.org/18438
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I176c8508de20e729d7c8b851aa3733cc0aa596cb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
