Omer Frenkel has posted comments on this change.

Change subject: core: cleanup in MigrateVmCommand
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 144:         }
Line 145:         ExecutionHandler.setAsyncJob(getExecutionContext(), true);
Line 146:     }
Line 147: 
Line 148:     private MigrateVDSCommandParameters 
getMigrateVDSCommandParameters() {
maybe call it create instead of get
Line 149:         String srcVdsHost = getVds().getHostName();
Line 150:         String dstVdsHost = String.format("%1$s:%2$s",
Line 151:                 getDestinationVds().getHostName(),
Line 152:                 getDestinationVds().getPort());


-- 
To view, visit http://gerrit.ovirt.org/18467
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I138ac8c64e7c0fe70c579e80313b56d4d1d47848
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to