Daniel Erez has posted comments on this change. Change subject: webadmin: Failed add a host via “Guide Me” on Local Data Center ......................................................................
Patch Set 2: Code-Review+1 (1 comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java Line 185: setSelectionModel(new SingleSelectionModel<EntityModel>()); Line 186: break; Line 187: } Line 188: Line 189: setSelectionChangeHandler(); for consistency/symmetry - consider renaming: * s/setSelectionChangeHandler/addSelectionChangeHandler * s/buildAddCheckBox/addCheckBoxColumn Line 190: buildAddCheckBox(hideCheckbox, showSelectAllCheckbox); Line 191: Line 192: } Line 193: -- To view, visit http://gerrit.ovirt.org/18450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bcb4c4824b58da345d30c70d0fe0c6ecc99a1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
