Sandro Bonazzola has posted comments on this change. Change subject: packaging: cleanups ......................................................................
Patch Set 1: (2 comments) .................................................... File ovirt-log-collector.spec.in Line 25: License: ASL 2.0 Line 26: URL: http://www.ovirt.org Line 27: Source: http://resources.ovirt.org/releases/nightly/src/%{package_name}-%{package_version}.tar.gz Line 28: Line 29: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) For Fedora >= 10 and EPEL >= 6 this should not be needed anymore. Line 30: BuildArch: noarch Line 31: Requires: python Line 32: Requires: python-dateutil Line 33: Requires: python-lxml Line 50: --disable-python-syntax-check Line 51: make %{?_smp_mflags} Line 52: Line 53: %install Line 54: rm -rf "%{buildroot}" The above line should not be needed anymore for Fedora >= 10 and EPEL >= 6 Line 55: make %{?_smp_mflags} install DESTDIR="%{buildroot}" Line 56: Line 57: %files Line 58: %doc AUTHORS -- To view, visit http://gerrit.ovirt.org/18447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b11a1eb73c02b87a8fd41954254f1031dfb1cdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
