Einav Cohen has posted comments on this change.
Change subject: userportal, webadmin: added favicon.ico to branding
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingServlet.java
Line 44: public void doGet(final HttpServletRequest request,
Line 45: final HttpServletResponse response) throws IOException,
Line 46: ServletException {
Line 47:
Line 48: if (request.getRequestURI().equals("/favicon.ico")) {
this website says exactly what Alexander explained above. We want to use
"method1", not "method2", as we don't want to configure every web-page in the
system separately. Did I miss something?
Line 49: String faviconPath =
brandingManager.getBrandedFaviconPath();
Line 50: if (faviconPath == null) {
Line 51: response.sendError(HttpServletResponse.SC_NOT_FOUND);
Line 52: }
--
To view, visit http://gerrit.ovirt.org/18385
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dcd9d0f22a7c5867c39576020ad16dd6c53deda
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
