Maor Lipchuk has uploaded a new change for review. Change subject: core: Use container id for memory lock in import process. ......................................................................
core: Use container id for memory lock in import process. When importing a VM we use memory lock on the VM in the export domain so it will not get deleted in the process. When the import process is being done with clone, a new vm id is generated and the lock, at the end command, is being regenerated with the new VM guid instead of the original one from the export domain. The proposed fix is to use the container id from the parameters when generating the shared lock. Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> Bug-Url: https://bugzilla.redhat.com/998907 Change-Id: Ie849300bdc98020aeca90deeddafd12295e8211a --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/18416/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java index 19ea437..d46d225 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java @@ -134,7 +134,7 @@ @Override protected Map<String, Pair<String, String>> getSharedLocks() { - return Collections.singletonMap(getVmId().toString(), + return Collections.singletonMap(super.getVmId().toString(), LockMessagesMatchUtil.makeLockingPair( LockingGroup.REMOTE_VM, getVmIsBeingImportedMessage())); -- To view, visit http://gerrit.ovirt.org/18416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie849300bdc98020aeca90deeddafd12295e8211a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
