Vojtech Szocs has posted comments on this change. Change subject: userportal,webadmin: frontend refactor phase 2 ......................................................................
Patch Set 6: Small note regarding the use of "final" keyword: * performance-wise, in modern JVMs (server-side) "final" has little-to-zero effect [http://stackoverflow.com/a/7067312] and in GWT (client-side) "final" has exactly-zero effect * design-wise, "final" should be used to reduce mutability and make it harder to break class invariants (i.e. init dependency via constructor, optionally checking if it's non-null, vs. allowing caller to modify dependency sometime after instance creation) -- To view, visit http://gerrit.ovirt.org/17356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id19491b8fd4f30ad3a88790eaad664d679b35e22 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
