Gilad Chaplik has posted comments on this change.

Change subject: webadmin: refactor volume list action availability
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

minor comment, you may address to it before merging.

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 350:             allowStart = true;
Line 351:             allowStop = true;
Line 352:             allowRemove = true;
Line 353:             allowStartRebalance = true;
Line 354:             allowOptimize = true;
redundant lines (initialized with true)
Line 355: 
Line 356:             for (GlusterVolumeEntity volume : 
Linq.<GlusterVolumeEntity> cast(getSelectedItems())) {
Line 357:                 if (volume.getStatus() == GlusterStatus.UP) {
Line 358:                     allowStart = false;


-- 
To view, visit http://gerrit.ovirt.org/18383
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f003dfe536189e1fa1d38e380e7acb7db208a22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to