Alona Kaplan has posted comments on this change.
Change subject: webadmin: Moved NeutronAgentWidget to appropriate package
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/NeutronAgentWidget.java
Line 34:
Line 35: interface ViewIdHandler extends
ElementIdHandler<NeutronAgentWidget> {
Line 36: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 37: }
Line 38:
Why do you still use CommonApplicationConstants and ApplicationConstants?
Line 39: private static CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
Line 40: private static CommonApplicationTemplates templates =
GWT.create(CommonApplicationTemplates.class);
Line 41:
Line 42: @UiField(provided = true)
Line 35: interface ViewIdHandler extends
ElementIdHandler<NeutronAgentWidget> {
Line 36: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 37: }
Line 38:
Line 39: private static CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
same
Line 40: private static CommonApplicationTemplates templates =
GWT.create(CommonApplicationTemplates.class);
Line 41:
Line 42: @UiField(provided = true)
Line 43: EntityModelWidgetWithInfo mappings;
--
To view, visit http://gerrit.ovirt.org/18334
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If58df722ed8da8f45b377ac66900945d3a4c713a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
