Vojtech Szocs has posted comments on this change. Change subject: webadmin: Added infrastructure for linking to System Tree items ......................................................................
Patch Set 24: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextColumnWithTooltip.java Line 14: this(TextCellWithTooltip.UNLIMITED_LENGTH); Line 15: } Line 16: Line 17: public TextColumnWithTooltip(int maxTextLength) { Line 18: super(new TextCellWithTooltip(maxTextLength)); You might consider calling this instead of super here when passing cell. Line 19: } Line 20: Line 21: public TextColumnWithTooltip(TextCellWithTooltip cell) { Line 22: super(cell); -- To view, visit http://gerrit.ovirt.org/15522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799aa4dfcd8ad7264057810e408cd1c64ea711e8 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches