Allon Mureinik has posted comments on this change.
Change subject: engine,webadmin: Limit usage of Local ISO SD to Local DC
......................................................................
Patch Set 7: Code-Review+1
(2 comments)
+1 on the backend side, see minor corrections to inline comments.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportStorageModelBehavior.java
Line 78: }
Line 79:
Line 80: private boolean isItemSelectable(IStorageModel item, StoragePool
dataCenter, boolean isNoStorageAttached) {
Line 81: // Local SD can be attached to the local DC only
Line 82: if (isLocalStorage(item) && !isLocalDataCenter(dataCenter)) {
s/the local/a local/
Line 83: return false;
Line 84: }
Line 85:
Line 86: // All storage domain can be attached to Unassigned DC
Line 82: if (isLocalStorage(item) && !isLocalDataCenter(dataCenter)) {
Line 83: return false;
Line 84: }
Line 85:
Line 86: // All storage domain can be attached to Unassigned DC
s/domain/domains/
Line 87: if
(dataCenter.getId().equals(StorageModel.UnassignedDataCenterId)) {
Line 88: return true;
Line 89: }
Line 90:
--
To view, visit http://gerrit.ovirt.org/18229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cfc3bb68581664fa6729e5cb8a163324e7fbc29
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
