Allon Mureinik has posted comments on this change. Change subject: core: allow using cloud init only from 3.3 ......................................................................
Patch Set 4: Code-Review-1 (1 comment) @Omer - see inline comment in 0000_config.sql @Cheryn - please take a look at the new message at backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties .................................................... File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 205: select fn_db_add_config_value('NetworkQosSupported','false','3.1'); Line 206: select fn_db_add_config_value('NetworkQosSupported','false','3.2'); Line 207: select fn_db_add_config_value('CloudInitSupported','false','3.0'); Line 208: select fn_db_add_config_value('CloudInitSupported','false','3.1'); Line 209: select fn_db_add_config_value('CloudInitSupported','false','3.2'); Don't rely on the default. Please add select fn_db_add_config_value('CloudInitSupported','true','3.3'); Line 210: Line 211: -- by default use no proxy Line 212: select fn_db_add_config_value('SpiceProxyDefault','','general'); Line 213: -- To view, visit http://gerrit.ovirt.org/17476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88d4ba3ca4dc24bdd3c12aeaf8168683e60096d9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryn...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches