Moti Asayag has posted comments on this change. Change subject: engine: Add profile validation to VmNicValidator ......................................................................
Patch Set 4: Code-Review+2 (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java Line 70: } Line 71: Line 72: // Check that if the profile contains QoS it is supported in the current cluster's version Line 73: if (!FeatureSupported.networkQoS(version) Line 74: && vnicProfile.getNetworkQosId() != null) there is no need for a new line here. Line 75: return new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_NETWROK_QOS_IS_NOT_SUPPORTED, Line 76: clusterVersion()); Line 77: } Line 78: return ValidationResult.VALID; -- To view, visit http://gerrit.ovirt.org/18178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic58cbcdc412ca8ae86f7694148725730aa10acb9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
