Maor Lipchuk has posted comments on this change.
Change subject: core: RecoveryStoragePool - adding further domain checks
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
Line 68
Line 69
Line 70
Line 71
Line 72
Please remove the enum and appErrors of
ERROR_CANNOT_RECOVERY_STORAGE_POOL_STORAGE_TYPE_MISSMATCH
It will not be used any more
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 373: ACTION_TYPE_FAILED_STORAGE_CONNECTION_BELONGS_TO_SEVERAL_DISKS=Cannot
${action} ${type}. Storage connection parameters are used by the following
disks : ${diskNames}.
Line 374:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_WRONG_PARAMETERS_FOR_STORAGE_TYPE=Cannot
${action} ${type}. Connection parameters are invalid for this storage type.
Line 375:
ACTION_TYPE_FAILED_STORAGE_CONNECTION_UNSUPPORTED_CHANGE_STORAGE_TYPE=Cannot
${action} ${type}. Storage type cannot be edited.
Line 376: ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST=Cannot ${action} ${type}.
Storage Domain doesn't exist.
Line 377: ACTION_TYPE_FAILED_WRONG_STORAGE_DOMAIN_TYPE==Cannot ${action}
${type}. The operation can be done using ${StorageDomainType} Storage Domain.
I think this message is more better:
Cannot ${action} ${type}. The storage domain type is not compatible. The
supported storage type for the storage domain is ${StorageDomainType}.
Message should be assembled with result:("Cannot action type"), Reason,
suggestion for solution.
Line 378: ACTION_TYPE_FAILED_CANNOT_CHANGE_STORAGE_DOMAIN_TYPE=Cannot ${action}
${type}. Cannot change Storage Domain type.
Line 379: ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL=Cannot ${action}
${type}. The relevant Storage Domain is inaccessible.\n\
Line 380: -Please handle Storage Domain issues and retry the operation.
Line 381: ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL2=Cannot ${action}
${type}. Storage status is ${status}.\n\
--
To view, visit http://gerrit.ovirt.org/18162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0d2d0b57d5b82f9b1dc4871db7dc1711777e16d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
