Sandro Bonazzola has posted comments on this change.
Change subject: agent, broker: additional vm control including migration
......................................................................
Patch Set 2:
(1 comment)
....................................................
File ovirt_hosted_engine_ha/agent/hosted_engine.py
Line 688: except KeyError:
Line 689: self._log.error("Invalid engine status: %s", status,
exc_info=True)
Line 690: return 0
Line 691:
Line 692: def handler_cleanup(f):
I think that this decorator should not be a method of HostedEngine class. i
suggest to refactor this to be a normal decorator function, moving this at
module scope.
Line 693: """
Line 694: Call a cleanup function when transitioning out of a state
Line 695: (i.e. when the handler returns a state other than its own)
Line 696: """
--
To view, visit http://gerrit.ovirt.org/18231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I842f30e6d1533ae4be227508999cd96b3e4963c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
