Omer Frenkel has posted comments on this change.

Change subject: core: Add POWER 7 to the CPU list
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/ServerCpuParser.java
Line 27:     /* Format is <level>:<name>:<flag>,<flag>,...:<verb>
Line 28:      *
Line 29:      * e.g. 3:Intel Xeon Core2:vmx,nx,model_Conroe:Conroe
Line 30:      *
Line 31:      */
please update the doc with the new format
Line 32:     public static ServerCpu parseCpu(String str) {
Line 33:         String[] parts = str.split("[:]", -1);
Line 34: 
Line 35:         if (parts.length != 5) {


-- 
To view, visit http://gerrit.ovirt.org/17853
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to