Alona Kaplan has posted comments on this change.
Change subject: webadmin: Refactored more code into NeutronAgentModel
......................................................................
Patch Set 10: Code-Review+2
(3 comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/provider/NeutronAgentWidget.java
Line 35: interface ViewIdHandler extends
ElementIdHandler<NeutronAgentWidget> {
Line 36: ViewIdHandler idHandler = GWT.create(ViewIdHandler.class);
Line 37: }
Line 38:
Line 39: private static CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
AFAIK creating the instance via inject is more efficient.
Line 40: private static CommonApplicationTemplates templates =
GWT.create(CommonApplicationTemplates.class);
Line 41:
Line 42: @UiField(provided = true)
Line 43: EntityModelWidgetWithInfo mappings;
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
Line 357: <t:content>
Line 358: <g:FlowPanel>
Line 359: <w:EntityModelWidgetWithInfo
ui:field="networkProvider"/>
Line 360: <e:ListModelListBoxEditor
ui:field="networkProviderTypeEditor" />
Line 361: <e:ListModelSuggestBoxEditor ui:field =
"providerPluginTypeEditor" />
TWS
Line 362: <g:FlowPanel
ui:field="neutronAgentPanel" addStyleNames="{style.sectionStyle}">
Line 363: <p:NeutronAgentWidget
ui:field="neutronAgentWidget" />
Line 364: </g:FlowPanel>
Line 365: </g:FlowPanel>
Line 358: <g:FlowPanel>
Line 359: <w:EntityModelWidgetWithInfo
ui:field="networkProvider"/>
Line 360: <e:ListModelListBoxEditor
ui:field="networkProviderTypeEditor" />
Line 361: <e:ListModelSuggestBoxEditor ui:field =
"providerPluginTypeEditor" />
Line 362: <g:FlowPanel
ui:field="neutronAgentPanel" addStyleNames="{style.sectionStyle}">
TWS
Line 363: <p:NeutronAgentWidget
ui:field="neutronAgentWidget" />
Line 364: </g:FlowPanel>
Line 365: </g:FlowPanel>
Line 366: </t:content>
--
To view, visit http://gerrit.ovirt.org/17251
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c4bc0c6aa3a27d7ef6a5b9b5e3fa5007f332561
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
