Tal Nisan has posted comments on this change.
Change subject: core: Remove member init in business entities
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
Line 89: String origin,
Line 90: int customEventId,
Line 91: int eventFloogInSec,
Line 92: String customData) {
Line 93: this(al_type,
I have to say I hate this 'al_' prefix, makes everything here so unreadable
Line 94: al_severity,
Line 95: al_msg,
Line 96: al_user_id,
Line 97: al_user_name,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapUser.java
Line 15: // TODO - Note ??? (Miki)
Line 16: // TODO - DesktopDevice ?? (Miki)
Line 17:
Line 18: private static final long serialVersionUID = 6800096193162766377L;
Line 19: private Guid mUserId ;
Unnecessary spaces or it's just Gerrit?
Line 20: private String mUserName;
Line 21: private String mPassword;
Line 22: private String mDomainControler;
Line 23: private String mName;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleType.java
Line 8: ADMIN(1),
Line 9: USER(2);
Line 10:
Line 11: private int id;
Line 12: private static final Map<Integer, RoleType> map = new
HashMap<Integer, RoleType>(RoleType.values().length);
Spaces?
Line 13:
Line 14: static {
Line 15: for (RoleType t : RoleType.values()) {
Line 16: map.put(t.id, t);
--
To view, visit http://gerrit.ovirt.org/18133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e8eb9ccb0e68db936489110d7f5c5828d07fab4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
