Alona Kaplan has posted comments on this change.
Change subject: webadmin: Added provider explanation in Add Host
......................................................................
Patch Set 10: Code-Review+2
(4 comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
Line 534: // Check boxes
Line 535: pmEnabledEditor = new EntityModelCheckBoxEditor(Align.RIGHT);
Line 536: externalHostProviderEnabledEditor = new
EntityModelCheckBoxEditor(Align.RIGHT);
Line 537:
Line 538: externalProviderLabel = new EntityModelLabel();
If you use default ctor why should it be provided (provided = true)?
Line 539: externalProviderEditor = new
ListModelListBoxOnlyEditor<Object>(new NullSafeRenderer<Object>() {
Line 540: @Override
Line 541: public String renderNullSafe(Object object) {
Line 542: return ((Provider) object).getName();
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
Line 356: <t:DialogTab ui:field="networkProviderTab">
Line 357: <t:content>
Line 358: <g:FlowPanel>
Line 359: <w:EntityModelWidgetWithInfo
ui:field="externalProvider"/>
Line 360: <e:ListModelListBoxEditor
ui:field="providerTypeEditor" />
TWS
Line 361: <e:ListModelSuggestBoxEditor ui:field =
"providerPluginTypeEditor" />
Line 362: <g:FlowPanel
ui:field="neutronAgentPanel" addStyleNames="{style.sectionStyle}">
Line 363: <p:NeutronAgentWidget
ui:field="neutronAgentWidget" />
Line 364: </g:FlowPanel>
Line 357: <t:content>
Line 358: <g:FlowPanel>
Line 359: <w:EntityModelWidgetWithInfo
ui:field="externalProvider"/>
Line 360: <e:ListModelListBoxEditor
ui:field="providerTypeEditor" />
Line 361: <e:ListModelSuggestBoxEditor ui:field =
"providerPluginTypeEditor" />
TWS
Line 362: <g:FlowPanel
ui:field="neutronAgentPanel" addStyleNames="{style.sectionStyle}">
Line 363: <p:NeutronAgentWidget
ui:field="neutronAgentWidget" />
Line 364: </g:FlowPanel>
Line 365: </g:FlowPanel>
Line 358: <g:FlowPanel>
Line 359: <w:EntityModelWidgetWithInfo
ui:field="externalProvider"/>
Line 360: <e:ListModelListBoxEditor
ui:field="providerTypeEditor" />
Line 361: <e:ListModelSuggestBoxEditor ui:field =
"providerPluginTypeEditor" />
Line 362: <g:FlowPanel
ui:field="neutronAgentPanel" addStyleNames="{style.sectionStyle}">
TWS
Line 363: <p:NeutronAgentWidget
ui:field="neutronAgentWidget" />
Line 364: </g:FlowPanel>
Line 365: </g:FlowPanel>
Line 366: </t:content>
--
To view, visit http://gerrit.ovirt.org/17142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8a1bd0565fe7115b171f465595fe157b4eefc2d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
