Omer Frenkel has posted comments on this change. Change subject: core: Normalize default VM time zone representation ......................................................................
Patch Set 1: although the change looks ok, from looking at the code it seems that every usage of getTimeZone() is checking first if the value is null or empty and gives the same treatment to null or empty, so i don't understand how changing from empty to null fix anything..? can you please elaborate? -- To view, visit http://gerrit.ovirt.org/17672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5ffcfef3b2f1930e65c2f66e26c265df31e0813 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches