Allon Mureinik has posted comments on this change.
Change subject: core: fix NPE in VdsUpdateRunTimeInfo
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1976:
Line 1977: for (DiskImageDynamic imageDynamic :
_runningVms.get(vmToUpdate.getId()).getVmDynamic().getDisks()) {
Line 1978: Disk disk =
getDbFacade().getDiskDao().get(imageDynamic.getId());
Line 1979: // We have disk_id statistics, which is good, but
disk_image_dynamic table contains image_id, so we
Line 1980: // update for the AI.
please add an inline comment here to explain why the disk can be null
Line 1981: if (disk != null && disk.getDiskStorageType() ==
DiskStorageType.IMAGE) {
Line 1982: DiskImage diskImage = (DiskImage) disk;
Line 1983: Guid activeImageId = diskImage.getImageId();
Line 1984: imageDynamic.setId(activeImageId);
--
To view, visit http://gerrit.ovirt.org/18142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a3a02485766253fa63eb3260f60b83899bfd317
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
