Yaniv Bronhaim has posted comments on this change.

Change subject: API: Do not require root password for host operations
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 2038:       parameterType: Action
Line 2039:       signatures:
Line 2040:       - mandatoryArguments: {}
Line 2041:         optionalArguments: {action.root_password: 'xs:string', 
action.image: 'xs:string'}
Line 2042:         deprecated: true
apparently the offset is fine.. the /api?rsdl returns with:

This XML file does not appear to have any style information associated with it. 
The document tree is shown below. -> and the content.

The only problem was in one test. fixed in next patchset.

mvn clean install goes smoothly.
Line 2043:       - mandatoryArguments: {}
Line 2044:         optionalArguments: {action.ssh.password: 'xs:string', 
action.image: 'xs:string'}
Line 2045:     urlparams: {}
Line 2046:     headers:


-- 
To view, visit http://gerrit.ovirt.org/18002
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I506b844df10acfc17dcbce271755d37fdcdf0c7e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to