Federico Simoncelli has posted comments on this change.

Change subject: frontend: identify user roles using enum values
......................................................................


Patch Set 1:

@Libor and @Omer, you added CHANGE_VM_CUSTOM_PROPERTIES, 
EDIT_ADMIN_VM_PROPERTIES and EDIT_ADMIN_TEMPLATE_PROPERTIES to  
getUserActionGroups even if they're advertised as RoleType.ADMIN in ActionGroup.

Which category is the correct one? ADMIN or USER?

-- 
To view, visit http://gerrit.ovirt.org/18145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2de0478fc80952c9a5816bd58a1d000df77a6681
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to