Arik Hadas has posted comments on this change.
Change subject: core: change iso prefix command to be vds broker command
......................................................................
Patch Set 8:
(2 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IsoPrefixVDSCommand.java
Line 23: }
Line 24:
Line 25: private String getIsoPrefix() {
Line 26: Guid storagePoolId = getParameters().getStoragePoolId();
Line 27: if (!storagePoolIdToIsoPrefix.containsKey(storagePoolId)) {
why they are not used to it? it was that way before, and it still is in other
commands that extends IrsBrokerCommand such as IsoDirectoryCommand..
I'm not against such change. I think it is redundant and as we think this
command should be replaced anyway, I don't want to waste the time on trying to
improve it now. this change is a minimal one that is made to fix a problem that
was detected.
Line 28: synchronized(getLockObjForStoragePool(storagePoolId)) {
Line 29: if
(!storagePoolIdToIsoPrefix.containsKey(storagePoolId)) {
Line 30: try {
Line 31: StoragePoolInfoReturnForXmlRpc retVal =
Line 44: }
Line 45: return storagePoolIdToIsoPrefix.get(storagePoolId);
Line 46: }
Line 47:
Line 48: static void clearCachedIsoPrefix(Guid storagePoolId) {
it should not return null, you're right about this one
Line 49: storagePoolIdToIsoPrefix.remove(storagePoolId);
Line 50: }
Line 51:
Line 52: private static Object getLockObjForStoragePool(Guid storagePoolId)
{
--
To view, visit http://gerrit.ovirt.org/17815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I272ce7b0407bf83bd47646941630362ecf0b18cc
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
