plysan has posted comments on this change.
Change subject: engine: check active vds before activate storage domain
......................................................................
Patch Set 2:
(2 comments)
Hi Allon:
Its good to be back !
I'll update the patch set. And see my comment in line if you're interested.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
Line 212: for (VDS vds : vdss) {
Line 213: if (vds.getStatus() == VDSStatus.Up) {
Line 214: return true;
Line 215: }
Line 216: }
Hi Allon:
Thanks for the tip! but I think there may be some misunderstanding in my commit
message :P
According to my knowledge, a 'up' host in a cluster can only be elected as a
SPM role after all the 'up' host in the cluster has verified the connection
with the storage. The SPM host only exist when there is up SD.
So when both storage and host are maintained in a DC, there can't be any SPM
host. What engine can do is make sure there exists 'up' host in the datacenter
to be elected as SPM after user press the button to activate the SD.
So I think it may not need any change here. What I need is to update my commit
message in the next patch set to be more accurate.
What do you think?
Thanks :)
Line 217:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_ACTIVE_HOST_IN_STORAGE_POOL);
Line 218: return false;
Line 219: }
Line 220:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 471:
ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL(ErrorType.BAD_PARAMETERS),
Line 472:
ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL(ErrorType.CONFLICT),
Line 473:
ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST(ErrorType.CONFLICT),
Line 474:
ACTION_TYPE_FAILED_MASTER_STORAGE_DOMAIN_NOT_ACTIVE(ErrorType.CONFLICT),
Line 475:
ACTION_TYPE_FAILED_NO_ACTIVE_HOST_IN_STORAGE_POOL(ErrorType.CONFLICT),
Thanks for the tip Allon, I'll make it happen in my next patch set.
Line 476: STORAGE_DOMAIN_NOT_ATTACHED_TO_STORAGE_POOL(ErrorType.CONFLICT),
Line 477:
ERROR_CANNOT_DETACH_STORAGE_DOMAIN_WITH_IMAGES(ErrorType.CONFLICT),
Line 478: ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN(ErrorType.CONFLICT),
Line 479:
ERROR_CANNOT_ATTACH_MORE_THAN_ONE_EXPORT_DOMAIN(ErrorType.CONFLICT),
--
To view, visit http://gerrit.ovirt.org/17940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e45b53d15b757237af8c76457f213c00a73909
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: plysan <ply...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: LiJiansheng <lijiangshe...@gmail.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: plysan <ply...@gmail.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
