Yair Zaslavsky has uploaded a new change for review.
Change subject: core: Improve CommandsFactory exception logging
......................................................................
core: Improve CommandsFactory exception logging
Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405
Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/18141/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
index 5210642..c5f5b52 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
@@ -1,6 +1,7 @@
package org.ovirt.engine.core.bll;
import java.lang.reflect.Constructor;
+import java.lang.reflect.InvocationTargetException;
import java.text.MessageFormat;
import java.util.Arrays;
import java.util.concurrent.ConcurrentHashMap;
@@ -49,11 +50,12 @@
return (CommandBase<P>) constructor.newInstance(new Object[] {
parameters });
}
-
- catch (Exception e) {
- log.error(
- "CommandsFactory [parameter: VdcActionParametersBase]:
Failed to get type information using " +
- "reflection for Action: " + action, e);
+ catch (InvocationTargetException ex) {
+ log.error("Error in invocating CTOR of command " + action.name() +
". Exception is ", ex);
+ return null;
+ }
+ catch (Exception ex) {
+ log.error("An exception has occured while trying to create a
command object for command " + action.name(), ex);
return null;
}
}
--
To view, visit http://gerrit.ovirt.org/18141
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fe9337ca429574d99d9971e7c59219cf2dc7405
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
