Allon Mureinik has uploaded a new change for review. Change subject: engine: Remove LUNs unused ctor ......................................................................
engine: Remove LUNs unused ctor Removed a constructor for LUNs only used by tests. Change-Id: I7ccdf1cc5fef4f4fc3977b274090604c1da42398 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java 2 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/18107/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java index 9e8c291..f3e55f7 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUNs.java @@ -11,12 +11,7 @@ private static final long serialVersionUID = 3026455643639610091L; public LUNs() { - } - - public LUNs(String lUN_id, String physical_volume_id, String volume_group_id) { - this.id = lUN_id; - this.physicalVolumeId = physical_volume_id; - this.volumeGroupId = volume_group_id; + lunType = StorageType.UNKNOWN; } @Override @@ -205,7 +200,7 @@ pathsDictionary = value; } - private StorageType lunType = StorageType.forValue(0); + private StorageType lunType; public StorageType getLunType() { return lunType; diff --git a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java index 7d851f0..5d38e17 100644 --- a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java +++ b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostStorageResourceTest.java @@ -111,7 +111,8 @@ @Override protected LUNs getEntity(int index) { - LUNs entity = new LUNs(GUIDS[index].toString(), null, null); + LUNs entity = new LUNs(); + entity.setLUN_id(GUIDS[index].toString()); entity.setLunType(org.ovirt.engine.core.common.businessentities.StorageType.ISCSI); return entity; } -- To view, visit http://gerrit.ovirt.org/18107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ccdf1cc5fef4f4fc3977b274090604c1da42398 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches