Allon Mureinik has uploaded a new change for review. Change subject: engine: Clean up GetNewVdsFenceStatusParamers ......................................................................
engine: Clean up GetNewVdsFenceStatusParamers Removed member (and methods to initialize them) that are not used by the query itself, and thus are redundant. Change-Id: I36ff5d00f92721333974a0ecf649a137a577854a Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 1 insertion(+), 54 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/18131/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java index 5b430da..e9450d0 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java @@ -1,6 +1,7 @@ package org.ovirt.engine.core.common.queries; import java.util.HashMap; + import org.ovirt.engine.core.common.businessentities.FenceAgentOrder; import org.ovirt.engine.core.compat.Guid; @@ -10,33 +11,6 @@ public GetNewVdsFenceStatusParameters() { _storagePoolId = Guid.Empty; } - - public GetNewVdsFenceStatusParameters(Guid vds_id, Guid vdsGroupId, Guid storagePolId, String managementIp, - HashMap<String, String> fencinOptions, String pmType, String user, String password, String pmProxyPreferences) { - _vds_id = vds_id; - _storagePoolId = storagePolId; - _managementIp = managementIp; - _fencingOptions = fencinOptions; - _pmType = pmType; - _user = user; - _password = password; - this.vdsGrouoId = vdsGroupId; - this.PmProxyPreferences = pmProxyPreferences; - this.order = FenceAgentOrder.Primary; - } - - public GetNewVdsFenceStatusParameters(Guid vds_id, Guid storagePolId, String managementIp, - HashMap<String, String> fencinOptions, String pmType, String user, String password, FenceAgentOrder order) { - _vds_id = vds_id; - _storagePoolId = storagePolId; - _managementIp = managementIp; - _fencingOptions = fencinOptions; - _pmType = pmType; - _user = user; - _password = password; - this.order = order; - } - private Guid _vds_id; @@ -106,32 +80,6 @@ public void setPassword(String value) { _password = value; - } - - private boolean _isNewHost; - - public boolean getIsNewHost() { - return _isNewHost; - } - - private Guid vdsGrouoId; - - public Guid getVdsGrouoId() { - return vdsGrouoId; - } - - public void setVdsGrouoId(Guid vdsGrouoId) { - this.vdsGrouoId = vdsGrouoId; - } - - private String PmProxyPreferences; - - public String getPmProxyPreferences() { - return PmProxyPreferences; - } - - public void setPmProxyPreferences(String pmProxyPreferences) { - PmProxyPreferences = pmProxyPreferences; } private FenceAgentOrder order; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java index f9de2a5..b8c37f6 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java @@ -1521,7 +1521,6 @@ param.setPassword(isPrimary ? (String) getPmPassword().getEntity() : (String) getPmSecondaryPassword().getEntity()); param.setStoragePoolId(cluster.getStoragePoolId() != null ? cluster.getStoragePoolId() : Guid.Empty); param.setFencingOptions(getPmOptionsMap()); - param.setPmProxyPreferences(getPmProxyPreferences()); Frontend.RunQuery(VdcQueryType.GetNewVdsFenceStatus, param, new AsyncQuery(this, new INewAsyncCallback() { -- To view, visit http://gerrit.ovirt.org/18131 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I36ff5d00f92721333974a0ecf649a137a577854a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches