Yair Zaslavsky has posted comments on this change.

Change subject: core: fix JSON serialization issues in VmPayload
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
Line 74:      * this is a calculated field our of the inner members.
Line 75:      * no need to de-serialize this as it is not a getter of a field.
Line 76:      * @return
Line 77:      */
Line 78:     @JsonIgnore
Have you checked that it works?
For some reason, I recall that JsonIgnore did not work for me without Mixin , 
and it was not long ago.
Line 79:     public Map<String, Object> getSpecParams() {
Line 80:         // function produce something like that:
Line 81:         // 
vmPayload={volumeId:volume-id,file:{filename:content,filename2:content2,...}}
Line 82:         Map<String, Object> specParams = new HashMap<String, Object>();


-- 
To view, visit http://gerrit.ovirt.org/18009
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief9e04e12a05b39cb5d2bceea5a23fbb05d01b09
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to