Yair Zaslavsky has posted comments on this change.

Change subject: core: LocalAdminPassword exception after engine restart
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java
Line 273:         if (values == null) {
Line 274:             values = new HashMap<String, Object>();
Line 275:             _vdcOptionCache.put(option.getoption_name(), values);
Line 276:         }
Line 277:         log.info("In updateOption decrypting and saving option 
"+option.getoption_name()+" version = "+option.getversion());
This looks more like a debug to me.
Can you please remove this one, or maybe have it as log.debug?
Line 278:         values.put(option.getversion(), GetValue(option));
Line 279:     }
Line 280: 
Line 281:     private static boolean isReloadable(String optionName) throws 
NoSuchFieldException {


-- 
To view, visit http://gerrit.ovirt.org/18065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to