Allon Mureinik has posted comments on this change.
Change subject: core: InitVdsOnUp - proceed regardless of problematic
iso/export domain
......................................................................
Patch Set 1:
(1 comment)
no unit tests?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 95: proxy.UpdateVdsDomainsData(vdsId, vdsName, vdsDomainData);
Line 96: }
Line 97: }
Line 98:
Line 99: public static List<Guid> checkIfDomainsReportedAsProblematic(Guid
storagePoolId, List<VDSDomainsData> vdsDomainsData) {
checkIfSomething sounds like a boolean method.
Why not call it getProblamaticDomains?
Line 100: IrsProxyData proxy = _irsProxyData.get(storagePoolId);
Line 101: if (proxy != null) {
Line 102: return
proxy.checkIfDomainsReportedAsProblematic(vdsDomainsData);
Line 103: }
--
To view, visit http://gerrit.ovirt.org/17986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32372aa80d7193a814f2500231d4545d2b1a5fc3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
