Ravi Nori has posted comments on this change.
Change subject: rest-api: validation of max parameter in restapi
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 132: String maxString = matrixConstraints.get(MAX);
Line 133: try {
Line 134: Integer max = Integer.valueOf(maxString);
Line 135: // fail if max is lt -1
Line 136: if (max.compareTo(-1) == -1){
max < 0 should be more readable
Line 137: return failMaxResults(maxString);
Line 138: }
Line 139: return max;
Line 140: } catch (NumberFormatException e) {
--
To view, visit http://gerrit.ovirt.org/18043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae3397dba4dffbff2ecf7d7601861540b52aa9bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
