Ravi Nori has posted comments on this change.

Change subject: core: Change enum JSON deserialization
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonEnumDeserializer.java
Line 30:             throws IOException, JsonProcessingException {
Line 31:         try {
Line 32:             return super.deserialize(jp, ctxt);
Line 33:         } catch (Exception ex) {
Line 34:             return null;
Should we log the exception
Line 35:         }
Line 36:     }


-- 
To view, visit http://gerrit.ovirt.org/17951
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to