Douglas Schilling Landgraf has posted comments on this change.
Change subject: frontend: node upgrade message improvement
......................................................................
Patch Set 2:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-08-12 17:06:52 -0400
Line 4: Commit: Douglas Schilling Landgraf <dougsl...@redhat.com>
Line 5: CommitDate: 2013-08-12 17:06:52 -0400
Line 6:
Line 7: frontend: rewrite hode has upgrade logic
Done
Line 8:
Line 9: Commit 5233548 required to be rewritten to match any revision.
Line 10:
Line 11: Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 674:
Line 675: for (RpmVersion iso: isos) {
Line 676: // Major check
Line 677: if (Integer.parseInt(version_host[0].trim()) ==
iso.getMajor()) {
Line 678: // Minor and Build
Hi Yair, I think this approach of Version that you are sharing is what have
been written with the previous patch (I could be missing a point here, please
let me know). To build the comparison string from vds.getHostOs() is kind of
difficult since it can be in many shapes as:
oVirt Node - 2.6.0 - 20130212.0.fc18
oVirt Node - 2.6.0 - 20130212.fc18
oVirt Node - 3.0.0 - 5.0.5.vdsm.fc19
RHEV Hypervisor - 6.4 - 20130709.0.el6_4
RHEV Hypervisor - 6.4 - 20130709.0.el6_4
I am not sure a way to split it and not take the ".fc18", ".el6" or even
".vdsm.fc19" to build a valid string for comparison to use with compareTo()?
Previously, node used date as revision. For 3.3 it will be numbers. I am open
to implement different approach once I have completely understood it. Thanks a
lot
Line 679: if (iso.getMinor() >
Integer.parseInt(version_host[1].trim()) ||
Line 680: iso.getBuild() >
Integer.parseInt(version_host[2].trim())) {
Line 681: alert = true;
Line 682: break;
--
To view, visit http://gerrit.ovirt.org/17987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76bd2948524110ec80923e855bd1f49e09e17046
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
