Omer Frenkel has posted comments on this change.
Change subject: core: prevent to run VM with cd-rom with no iso domain
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 787:
Line 788: getVm().setVmPayload(getParameters().getVmPayload());
Line 789: }
Line 790:
Line 791: if (!vm.isAutoStartup() &&
!StringUtils.isEmpty(getVm().getIsoPath())
please add a comment to explain what this if does, not sure its valid
Line 792: &&
getIsoDomainListSyncronizer().findActiveISODomain(getVm().getStoragePoolId())
!= null) {
Line 793: return
failCanDoAction(VdcBllMessages.VM_CANNOT_RUN_FROM_CD_WITHOUT_ACTIVE_STORAGE_DOMAIN_ISO);
Line 794: }
Line 795:
--
To view, visit http://gerrit.ovirt.org/17747
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idad3c5b812ce4744d3d610341e76af4c24ce0bae
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
