ofri masad has posted comments on this change.

Change subject: engine: Add QoS parameters to VmInfoBuilder
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 573:             if (networkQoS != null) {
Line 574:                 if (specParams == null) {
Line 575:                     specParams = new HashMap<>();
Line 576:                 }
Line 577:                 if (networkQoS.getInboundAverage() > 0) {
They do not. please look at the getters of networkQoS. they are different for 
each part.
Line 578:                     Map<String, String> inbound = new HashMap<>();
Line 579:                     inbound.put(VdsProperties.QOS_AVERAGE, 
String.valueOf(networkQoS.getInboundAverage()));
Line 580:                     inbound.put(VdsProperties.QOS_PEAK, 
String.valueOf(networkQoS.getInboundPeak()));
Line 581:                     inbound.put(VdsProperties.QOS_BURST, 
String.valueOf(networkQoS.getInboundBurst()));


-- 
To view, visit http://gerrit.ovirt.org/17975
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57bdcc24dfa99b81dc0b89f52e4007da5d6b2412
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to