Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Show only supported displays
......................................................................
Patch Set 1:
(1 comment)
just a very minor comment - please fix on rebase and I will give +2
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 158: private static List<Integer> linuxOsIds;
Line 159: // cached windows OS
Line 160: private static List<Integer> windowsOsIds;
Line 161:
Line 162: private static HashMap<Version, HashMap<Integer, Boolean>>
versionOsIdSpiceMap;
please define it as Map<...> not HashMap<...>
Line 163:
Line 164: public static String getDefaultConfigurationVersion() {
Line 165: return _defaultConfigurationVersion;
Line 166: }
--
To view, visit http://gerrit.ovirt.org/17885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c91524181a7fa1fc2961c85df9bb78f553aa1ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
