Leonardo Bianconi has posted comments on this change.
Change subject: core: Initial support for alternative architectures
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
Line 52: if (model.isSetVersion() &&
model.getVersion().getMajor()!=null && model.getVersion().getMinor()!=null) {
Line 53: entity.setcompatibility_version(new
org.ovirt.engine.core.compat.Version(model.getVersion().getMajor(),
Line 54:
model.getVersion().getMinor()));
Line 55: }
Line 56: if (model.isSetArchitecture()) {
Initially we have created this field as r/w, but it can cause mismatches
between cpu and architecture, so we changed it to read only and we left the
architecture in the rsdl_metadata.yaml file.
As it's read only now, we removed the architecture fields (in our working copy)
from the rsdl_metadata.yaml and it worked as we expected, so the architecture
field is specified only in the api.xsd. Is it correct? Are the read only API
fields specified only in the api.xsd?
Line 57: Architecture architecture =
Architecture.fromValue(model.getArchitecture());
Line 58: if (architecture != null) {
Line 59: entity.setArchitectureType(map(architecture, null));
Line 60: }
Line 53: entity.setcompatibility_version(new
org.ovirt.engine.core.compat.Version(model.getVersion().getMajor(),
Line 54:
model.getVersion().getMinor()));
Line 55: }
Line 56: if (model.isSetArchitecture()) {
Line 57: Architecture architecture =
Architecture.fromValue(model.getArchitecture());
It was removed since the architecture is a read only field.
Line 58: if (architecture != null) {
Line 59: entity.setArchitectureType(map(architecture, null));
Line 60: }
Line 61: }
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
