Moti Asayag has posted comments on this change. Change subject: core: Add Vnic Profile support to RemoveNetworkQoS ......................................................................
Patch Set 11: Code-Review+2 (1 comment) minor comment can be addressed later. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 270: GetAllNetworksForProvider, Line 271: Line 272: //Network QoS Line 273: GetAllNetworkQosByStoragePoolId, Line 274: GetAllProfilesByNetworkQosId, this should go under the // Vnic Profiles section. Please change the name to: GetVnicProfilesByNetworkQosId Line 275: Line 276: GetWatchdog(VdcQueryAuthType.User), Line 277: GetConsoleDevices(VdcQueryAuthType.User), Line 278: -- To view, visit http://gerrit.ovirt.org/17932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I401cff6b67b5fe62303323849f11bd9d03892201 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <oma...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <oma...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
