Roy Golan has posted comments on this change.

Change subject: core: log set VM ticket event
......................................................................


Patch Set 1:

(3 comments)

addressed all comments

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
Line 191:     }
Line 192: 
Line 193:     @Override
Line 194:     public AuditLogType getAuditLogTypeValue() {
Line 195:         return AuditLogType.VM_SET_TICKET;
Done
Line 196:     }


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
Line 91:     VAR__ACTION__END,
Line 92:     VAR__ACTION__CLEAR,
Line 93:     VAR__ACTION__FORCE_SELECT,
Line 94:     VAR__ACTION__EXTEND_IMAGE_SIZE,
Line 95:     VAR__ACTION__SET_TICKET,
this is a mistake
Line 96: 
Line 97:     // Host statuses replacements
Line 98:     VAR__HOST_STATUS__UP,
Line 99:     VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL,


....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 223: VM_MIGRATION_TRYING_RERUN=Migration failed${DueToMigrationError}. 
Trying to migrate to another Host (VM: ${VmName}, Source: ${VdsName}, 
Destination: ${VdsDestination}).
Line 224: VM_CANCEL_MIGRATION=Migration cancelled (VM: ${VmName}, Source: 
${VdsName}, User: ${UserName}).
Line 225: VM_CANCEL_MIGRATION_FAILED=Failed to cancel migration for VM: 
${VmName}
Line 226: VM_STATUS_RESTORED=VM ${VmName} status was restored to ${VmStatus}.
Line 227: VM_SET_TICKET=user initiated console session for VM ${VmName}
Done
Line 228: VDS_SLOW_STORAGE_RESPONSE_TIME=Slow storage response time on Host 
${VdsName}.
Line 229: IRS_HOSTED_ON_VDS=Storage Pool Manager runs on Host ${VdsName} 
(Address: ${ServerIp}).
Line 230: USER_ATTACH_VM_POOL_TO_AD_GROUP=Group ${AdGroupName} was attached to 
VM Pool ${VmPoolName} by ${UserName}.
Line 231: USER_ATTACH_VM_POOL_TO_AD_GROUP_INTERNAL=Group ${AdGroupName} was 
attached to VM Pool ${VmPoolName}.


-- 
To view, visit http://gerrit.ovirt.org/17742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61308fdd59d0d11b045a8e1ed72648c85f039701
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to