Michael Pasternak has posted comments on this change. Change subject: restapi: del storage conn if domain creation fails ......................................................................
Patch Set 1: this is not just having failback logic in the api, the way it implemented any exception can trigger removeStorageServerConnection(), just think of "insufficient permission" that ends up with ACTION_TYPE_FAILED_STORAGE_CONNECTION_NOT_EXIST or ACTION_TYPE_FAILED_STORAGE_CONNECTION_ID_EMPTY and there are lot more scenarios that can cause failure which eventually will end with error/s mentioned above, to solve this, you need to analyse the api error making different assumption/heuristics, so all i'm saying it's not worth the effort and makes sense doing this in the context of Add*StorageDomain right now where you aware of the cause/stage of failure -- To view, visit http://gerrit.ovirt.org/17658 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e354cb10e2438fae02b1dff41b2945b016d1e1b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
