Sandro Bonazzola has posted comments on this change. Change subject: ovirt-live: migrate ovirt live plugin to otopi ......................................................................
Patch Set 10: Code-Review-1 (2 comments) .................................................... File fedora/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py Line 72: stage=plugin.Stages.VALIDATION, Line 73: ) Line 74: def _validation(self): Line 75: import ovirtsdk.api Line 76: from ovirtsdk.xml import params import ovirtsdk.xml you can remove the above line importing only params because you're not using params in this method. Line 77: self._ovirtsdk_api = ovirtsdk.api Line 78: self._ovirtsdk_xml = ovirtsdk.xml Line 79: Line 80: @plugin.event( Line 168: oliveconst.Stages.OVIRTLIVE_COPY_ISO, Line 169: ), Line 170: ) Line 171: def _createvm(self): Line 172: # Defins OS param for the boot option params = self._ovirtsdk_xml.params Line 173: os = params.OperatingSystem( Line 174: type_='unassigned', Line 175: boot=( Line 176: params.Boot(dev='cdrom'), -- To view, visit http://gerrit.ovirt.org/17518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I703f64dc1183a6fe176d9d0352f93de381d906bb Gerrit-PatchSet: 10 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
