Ori Liel has posted comments on this change. Change subject: restapi: Support for gluster hooks added ......................................................................
Patch Set 7: (1 comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 3314: <xs:complexContent> Line 3315: <xs:extension base="BaseResource"> Line 3316: <xs:sequence> Line 3317: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 3318: <xs:element name="content_type" type="xs:string" minOccurs="0" maxOccurs="1" /> I understand that, but there are sill two reasons to use the 'status' element. One is consistency - we use the 'status' element everywhere else in the API where a status is needed. The second reason is that if in the future you will want to be able to add a more detailed message to the status, you will be able to to so without breaking API. So we would prefer using 'status' element here after all. Line 3319: <xs:element name="status" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3320: <xs:element name="checksum" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 3321: </xs:sequence> Line 3322: </xs:extension> -- To view, visit http://gerrit.ovirt.org/16512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9c0299977448e0b50feeed6e38a015c60b86fd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
