Moti Asayag has posted comments on this change.
Change subject: engine: Reuse VmInfoBuilder to add profile data to nic in VDS
commands
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 538: public static void addProfileDataToNic(Map<String, Object> struct,
Line 539: VM vm,
Line 540: VmDevice vmDevice,
Line 541: VmNic nic,
Line 542: Version clusterVersion) {
why there is a need for clusterVersion if this info can be retrieved from the
VM parameter ?
Line 543: VnicProfile vnicProfile = null;
Line 544: Network network = null;
Line 545: if (nic.getVnicProfileId() != null) {
Line 546: vnicProfile =
DbFacade.getInstance().getVnicProfileDao().get(nic.getVnicProfileId());
--
To view, visit http://gerrit.ovirt.org/17930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I234bb2854a5d2d8bdb97dd7d76d34167016c87e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
