Alissa Bonas has posted comments on this change.
Change subject: core: SyncLunsInfoForIscsiStorageDomain
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
Line 63: if (isSuccess && VDSCommandType.forValue(type) ==
VDSCommandType.ConnectStorageServer) {
Line 64: isSuccess = isConnectSucceeded((Map<String, String>)
returnValue.getReturnValue(), list);
Line 65:
Line 66: // Synchronize LUN details comprising the storage
domain with the DB
Line 67: StorageDomainParametersBase parameters = new
StorageDomainParametersBase(storageDomain.getId());
if I understand the code correctly, it is syncing luns info regardless of the
isSuccess value.
Perhaps it's not clear from the code, however what it does here is this:
isSuccess = returnValue.getSucceeded(); --> checks if the call to vdsm
succeeded. it does NOT indicate whether the connection to storage succeeded.
the second assignment to isSuccess (inside the if statement) is the actual
check whether the connection succeeded to storage.
So you'd probably need to wrap the luns syncing in an if statement to save the
syncing if connect to storage failed.
Line 68: parameters.setVdsId(vdsId);
Line 69:
Backend.getInstance().runInternalAction(VdcActionType.SyncLunsInfoForIscsiStorageDomain,
parameters);
Line 70: }
Line 71: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommand.java
Line 36: if (isLunsInfoMismatch(lunsFromVgInfo, lunsFromDb)) {
Line 37: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 38: @Override
Line 39: public Void runInTransaction() {
Line 40: log.infoFormat("LUN details mismatch has been
detected - refresh data from the underlying storage");
please add details regarding which storage connection/conn id is this, and
perhaps some info regarding the mismatch (optional) - otherwise it's not a very
helpful log message...
Line 41: refreshLunsInfo(lunsFromVgInfo, lunsFromDb);
Line 42: return null;
Line 43: }
Line 44: });
--
To view, visit http://gerrit.ovirt.org/17919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5867ad8d36f329e23c611079512be30a9c5f83a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
