Eli Mesika has uploaded a new change for review. Change subject: core: Add external event error messages need to be improved ......................................................................
core: Add external event error messages need to be improved Add external event error messages need to be improved Adding EventValidator class to validate severity enum values. The flood_rate can be omitted and the default is set to 30 (this was working prior to this patch) Change-Id: I743ff20bd3d4317bc054ba314ada6bd918a7502f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949551 Signed-off-by: Eli Mesika <emes...@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/29/17929/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java index 3d145bf..46a8430 100644 --- a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendEventsResource.java @@ -67,6 +67,7 @@ @Override public Response add(Event event) { validateParameters(event, "origin", "severity", "customId", "description"); + validateEnums(Event.class, event); return performCreate(VdcActionType.AddExternalEvent, new AddExternalEventParameters(map(event)), new QueryIdResolver<Long>(VdcQueryType.GetAuditLogById, GetAuditLogByIdParameters.class)); diff --git a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java new file mode 100644 index 0000000..a8c417a --- /dev/null +++ b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/EventValidator.java @@ -0,0 +1,17 @@ +package org.ovirt.engine.api.restapi.resource.validation; + +import static org.ovirt.engine.api.common.util.EnumValidator.validateEnum; + +import org.ovirt.engine.api.model.Event; +import org.ovirt.engine.api.model.LogSeverity; + +@ValidatedClass(clazz = Event.class) +public class EventValidator implements Validator<Event> { + + @Override + public void validateEnums(Event event) { + if (event.isSetSeverity()) { + validateEnum(LogSeverity.class, event.getSeverity(), true); + } + } +} -- To view, visit http://gerrit.ovirt.org/17929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I743ff20bd3d4317bc054ba314ada6bd918a7502f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
