Allon Mureinik has posted comments on this change.
Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific
VDS.
......................................................................
Patch Set 15:
in pseudocode:
MassOperationDAO:
updateAllInBatch(Collection<T> entities); // Note - this has nothing to do
with transaction management!
MassOperationsGenericDaoDbFacade:
abstract Mapper getBatchMapper();
updateAllInBatch(Collection<T> entities) {
updateAllInBatch (entities, getBatchMapper(), getUpdateProcedureName()); //
not sure about the order
}
Regarding the map - there's no sense in passing a map to a dao and then only
using its values(). Just pass the values() from the caller, and keep the dao
clean.
--
To view, visit http://gerrit.ovirt.org/16066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
