Laszlo Hornyak has uploaded a new change for review.
Change subject: engine: fix logging in ExternalSchedulerBrokerImpl
......................................................................
engine: fix logging in ExternalSchedulerBrokerImpl
when logging an error, log the exception as well
Change-Id: Id8fca5fcd7e5202ece4496f77048f393ce34030f
Signed-off-by: Laszlo Hornyak <lhorn...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/17862/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
index 2eee70c..a319a7e 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
@@ -51,7 +51,7 @@
return parseDiscoverResults(result);
} catch (XmlRpcException e) {
- log.error("Could not communicate with the external scheduler while
discovering" + e);
+ log.error("Could not communicate with the external scheduler while
discovering", e);
// TODO: decision is needed what to do here:
// - return all vds without filtering?
// - return empty vds list?
@@ -81,7 +81,7 @@
return parseFilterResults(result);
} catch (XmlRpcException e) {
- log.error("Could not communicate with the external scheduler while
filtering " + e);
+ log.error("Could not communicate with the external scheduler while
filtering ", e);
// TODO: decision is needed what to do here:
// - return all vds without filtering?
// - return empty vds list?
@@ -134,7 +134,7 @@
return parseScoreResults(result);
} catch (XmlRpcException e) {
- log.error("Could not communicate with the external scheduler while
running score functions " + e);
+ log.error("Could not communicate with the external scheduler while
running score functions ", e);
// TODO: decision is needed what to do here:
// - return all vds without filtering?
// - return empty vds list?
@@ -202,7 +202,7 @@
return parseBalanceResults(result);
} catch (XmlRpcException e) {
- log.error("Could not communicate with the external scheduler while
balancing " + e);
+ log.error("Could not communicate with the external scheduler while
balancing ", e);
// TODO: decision is needed what to do here:
// - return all vds without filtering?
// - return empty vds list?
--
To view, visit http://gerrit.ovirt.org/17862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8fca5fcd7e5202ece4496f77048f393ce34030f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
