[Engine-patches] Change in ovirt-engine[master]: webadmin: adding profile column to import vm/template and sn...

[masayag]

Hello Alona Kaplan,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/17859

to review the following change.

Change subject: webadmin: adding profile column to import vm/template and 
snapshot tables
......................................................................

webadmin: adding profile column to import vm/template and snapshot tables

This patch adds the profile column to vm interface tab in
import vm/template and snapshot tables after the network name column.

Change-Id: I7f7e5800058942ebc97446ed9b953ec6108df322
Signed-off-by: Alona Kaplan <alkap...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
3 files changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/59/17859/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
index 29a8f65..ad5f3f0 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java
@@ -63,6 +63,15 @@
         };
         getTable().addColumn(networkNameColumn, 
constants.networkNameInterface());
 
+        TextColumnWithTooltip<VmNetworkInterface> profileNameColumn = new 
TextColumnWithTooltip<VmNetworkInterface>() {
+            @Override
+            public String getValue(VmNetworkInterface object) {
+                return object.getVnicProfileName();
+            }
+        };
+
+        getTable().addColumn(profileNameColumn, 
constants.profileNameInterface());
+
         BooleanColumn<VmNetworkInterface> linkStateColumn =
                 new 
BooleanColumn<VmNetworkInterface>(constants.linkedNetworkInteface(),
                         constants.unlinkedNetworkInteface()) {
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
index ea5a44b..e979dd4 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotInfoPanel.java
@@ -208,6 +208,14 @@
         };
         nicsTable.addColumn(networkNameColumn, 
constants.networkNameInterface(), "80px"); //$NON-NLS-1$
 
+        TextColumnWithTooltip<VmNetworkInterface> profileNameColumn = new 
TextColumnWithTooltip<VmNetworkInterface>() {
+            @Override
+            public String getValue(VmNetworkInterface object) {
+                return object.getVnicProfileName();
+            }
+        };
+        nicsTable.addColumn(profileNameColumn, 
constants.profileNameInterface(), "80px"); //$NON-NLS-1$
+
         TextColumnWithTooltip<VmNetworkInterface> typeColumn = new 
EnumColumn<VmNetworkInterface, VmInterfaceType>() {
             @Override
             protected VmInterfaceType getRawValue(VmNetworkInterface object) {
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
index e8a20ab..fd12e2e 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java
@@ -368,6 +368,14 @@
         };
         nicTable.addColumn(networkColumn, constants.networkNameInterface(), 
"150px"); //$NON-NLS-1$
 
+        TextColumnWithTooltip<VmNetworkInterface> profileColumn = new 
TextColumnWithTooltip<VmNetworkInterface>() {
+            @Override
+            public String getValue(VmNetworkInterface object) {
+                return object.getVnicProfileName();
+            }
+        };
+        nicTable.addColumn(profileColumn, constants.profileNameInterface(), 
"150px"); //$NON-NLS-1$
+
         TextColumnWithTooltip<VmNetworkInterface> typeColumn = new 
EnumColumn<VmNetworkInterface, VmInterfaceType>() {
             @Override
             protected VmInterfaceType getRawValue(VmNetworkInterface object) {


-- 
To view, visit http://gerrit.ovirt.org/17859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f7e5800058942ebc97446ed9b953ec6108df322
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches