Maor Lipchuk has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 6:
(6 comments)
partial reviewed
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 130: VMT_CANNOT_UPDATE_ILLEGAL_FIELD=Failed updating the properties of the
VM template.
Line 131: DIRECTORY_GROUP_CANNOT_REMOVE_DIRECTORY_GROUP_ATTACHED_TO_VM=Cannot
remove Directory Group. Detach Directory Group from VM first.
Line 132: VM_NOT_FOUND=VM not found
Line 133: ACTION_TYPE_FAILED_VM_IN_PREVIEW=Cannot ${action} ${type}. VM is
previewing a Snapshot.
Line 134: ACTION_TYPE_FAILED_VM_HAS_PLUGGED_DISK_SNAPSHOT=Cannot ${action}
${type}. The following VM activated disks are snapshots: ${diskAliases}, please
deactivate them and try again.
remove the comma (switch to dot)
Line 135: ACTION_TYPE_FAILED_DISKS_LOCKED=Cannot ${action} ${type}: The
following disks are locked: ${diskAliases}. Please try again in a few minutes.
Line 136: ACTION_TYPE_FAILED_DISKS_ILLEGAL=Cannot ${action} ${type}. The
following attached disks are in ILLEGAL status: ${diskAliases} - please remove
them and try again.
Line 137: ACTION_TYPE_FAILED_IMPORT_DISKS_ALREADY_EXIST=Cannot ${action}
${type}. The following disks already exist: ${diskAliases}. Please import as a
clone.
Line 138: ACTION_TYPE_FAILED_VM_IS_LOCKED=Cannot ${action} ${type}: VM is
locked. Please try again in a few minutes.
Line 801: USER_CANNOT_BE_ADDED_TO_VM=User cannot be added to VM
Line 802: USER_CANNOT_BE_ADDED_TO_VM_POOL=User cannot be added to VM-Pool
Line 803: ACTION_TYPE_FAILED_DETECTED_PINNED_VMS=Cannot ${action} ${type}. The
following VMs are set to run specifically only on this Host: ${VmNames}.\nIn
order to ${action} ${type}, you need to remove the association between the VMs
and the Host (Using Edit VM properties).
Line 804: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
Line 805: HOT_PLUG_DISK_SNAPSHOT_IS_NOT_SUPPORTED=Hot-plug/Hot-unplug, is only
supported for Clusters of version 3.3 and above.
1. remove comma after hot-plug/hoy-unplug
2. Please change the message to indicate snapshot, as so : "Hot-plug/Hot-unplug
of snapshots is only supported for ...."
3. I would remove the hard coded version here (3.3) this is configurable, the
user can change it at any time, even for higher version clusters. I would just
write that this is not supported for the specific cluster version.
Line 806: UNLINKING_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Link state is
set to 'Down' on the virtual machine's interface, this is not supported for
clusters of version ${clusterVersion}.
Line 807: NULL_NETWORK_IS_NOT_SUPPORTED=Cannot ${action} ${type}. There is no
network on the virtual machine's interface, this is not supported for clusters
of version ${clusterVersion}.
Line 808: HOT_VM_INTERFACE_UPDATE_IS_NOT_SUPPORTED=Cannot ${action} ${type}.
Updating the virtual machine interface while the virtual machine is running is
not supported for clusters of version ${clusterVersion}.
Line 809: CANNOT_PERFOM_HOT_UPDATE=Cannot ${action} ${type}. Updating some of
the properties is not supported while the interface is plugged into a running
virtual machine. Please un-plug the interface, update the properties, and then
plug it back.
....................................................
File packaging/dbscripts/all_disks_sp.sql
Line 61: WHERE vm_device.vm_id = v_vm_guid and boot = true;
Line 62: END; $procedure$
Line 63: LANGUAGE plpgsql;
Line 64:
Line 65:
No change needed here. please remove empty line
Line 66: -- Returns all the attachable disks in the storage pool
Line 67: -- If storage pool is ommited, all the attachable disks are retrurned.
Line 68: -- in case vm id is provided, returning all the disks in SP that are
not attached to the vm
Line 69: Create or replace FUNCTION
GetAllAttachableDisksByPoolId(v_storage_pool_id UUID, v_vm_id uuid, v_user_id
UUID, v_is_filtered BOOLEAN)
....................................................
File
packaging/dbscripts/upgrade/03_03_0710_add_snapshot_id_column_to_vm_device.sql
Line 1: select fn_db_add_column('vm_device', 'snapshot_id', 'UUID REFERENCES
SNAPSHOTS(snapshot_id) ON DELETE CASCADE DEFAULT NULL');
snapshot_id could be misleading, I would suggest plugged_snapshot_id maybe...
What do you think?
....................................................
File packaging/dbscripts/vm_device_sp.sql
Line 152: AND (v_vm_id IS NULL OR vm_id = v_vm_id);
Line 153: END; $procedure$
Line 154: LANGUAGE plpgsql;
Line 155:
Line 156: Create or replace FUNCTION
GetVmDevicesBySnapshotIdExcludingVm(v_snapshot_id UUID, v_vm_id UUID)
this function is not used
Line 157: RETURNS SETOF vm_device_view
Line 158: AS $procedure$
Line 159: BEGIN
Line 160: RETURN QUERY
Line 205: END; $procedure$
Line 206: LANGUAGE plpgsql;
Line 207:
Line 208:
Line 209: Create or replace FUNCTION GetVmDeviceByVmIdTypeAndDevice(v_vm_id
UUID, v_type varchar(30), v_device varchar(30), v_user_id UUID, v_is_filtered
BOOLEAN)
Please remove the function it is not used
Line 210: RETURNS SETOF vm_device_view
Line 211: AS $procedure$
Line 212: BEGIN
Line 213: RETURN QUERY
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
